[jira] [Commented] (HDFS-7210) Avoid two separate RPC's namenode.append() and namenode.getFileInfo() for an append call from DFSClient

[Vinayakumar B (JIRA)]

    [ 
https://issues.apache.org/jira/browse/HDFS-7210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14228192#comment-14228192
 ] 

Vinayakumar B commented on HDFS-7210:
-------------------------------------

Thanks [~umamaheswararao]. 
+1 for the below delta changes added to the patch.
{code}           // add the op into retry cache is necessary
           if (toAddRetryCache) {
+            HdfsFileStatus stat = fsNamesys.dir.createFileStatus(
+                HdfsFileStatus.EMPTY_NAME, newFile,
+                BlockStoragePolicySuite.ID_UNSPECIFIED,
+                Snapshot.CURRENT_STATE_ID, false, iip);
             fsNamesys.addCacheEntryWithPayload(addCloseOp.rpcClientId,
-                addCloseOp.rpcCallId, lb);
+                addCloseOp.rpcCallId, new LastBlockWithStatus(lb, stat));
           }
         }{code}

> Avoid two separate RPC's namenode.append() and namenode.getFileInfo() for an 
> append call from DFSClient
> -------------------------------------------------------------------------------------------------------
>
>                 Key: HDFS-7210
>                 URL: https://issues.apache.org/jira/browse/HDFS-7210
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: hdfs-client, namenode
>            Reporter: Vinayakumar B
>            Assignee: Vinayakumar B
>         Attachments: HDFS-7210-001.patch, HDFS-7210-002.patch, 
> HDFS-7210-003.patch, HDFS-7210-004.patch, HDFS-7210-005.patch, 
> HDFS-7210-006.patch
>
>
> Currently DFSClient does 2 RPCs to namenode for an append operation.
> {{append()}} for re-opening the file and getting the last block, 
> {{getFileInfo()}} Another on to get HdfsFileState
> If we can combine result of these 2 calls and make one RPC, then it can 
> reduce load on NameNode.
> For the backward compatibility we need to keep existing {{append()}} call as 
> is



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)