[
https://issues.apache.org/jira/browse/HDFS-7438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14230518#comment-14230518
]
Charles Lamb commented on HDFS-7438:
------------------------------------
[~wheat9],
Thanks for continuing your FSN/FSD refactoring.
I have some comments, but overall I checked the code movement and it seems to
be a faithful refactoring.
FSDirRenameOp.java:
several lines bust the 80 char limit, but since these are exact cut-and-pastes
from FSDirectory.java we should probably not fix them now.
The formatting of the return for renameToInt() is off.
FSDirectory.java: I verified that the removal of "private" was necessary (it
is). I verified that the code moved to FSDirRenameOp was the same in both
places.
DFSTestUtil.java:
FSImage is an unused import.
Isn't @VisibleForTesting implied by the fact that it's in src/test?
FSEditLogLoader.java:
line 602 busts the 80 char limit.
FSNamesystem.java:
import AbstractMap is unused.
You moved the call to waitForLoadingFSImage() out of the writeLock() context,
but I think that's probably an improvement.
In renameToInternal, I like that you added the
@SuppressWarnings("deprecation"). Since you added the "boolean stat" out of the
if and into a decl, you might as well make it final too.
The call to logAuditEvent busts the 80 char limit.
> Consolidate implementation of rename()
> --------------------------------------
>
> Key: HDFS-7438
> URL: https://issues.apache.org/jira/browse/HDFS-7438
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Haohui Mai
> Assignee: Haohui Mai
> Attachments: HDFS-7438.000.patch, HDFS-7438.001.patch,
> HDFS-7438.002.patch, HDFS-7438.003.patch
>
>
> The implementation of {{rename()}} resides in both {{FSNameSystem}} and
> {{FSDirectory}}. This jira proposes to consolidate them in a single class.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
