[
https://issues.apache.org/jira/browse/HDFS-7459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14232441#comment-14232441
]
Charles Lamb commented on HDFS-7459:
------------------------------------
Hi [~wheat9],
Generally this LGTM.
FSNDNCacheOp.java:
THe formatting for listCacheDirectives is off (2nd line)
FSNamesystem.java:
In listCacheDirectives you removed the isAuditEnabled() &&
isExternalInvocation(). Was that intentional? Ditto #addCachePool,
#modifyCachePool and #removeCachePool, and #listCachePools.
> Consolidate cache-related implementation in FSNamesystem into a single class
> ----------------------------------------------------------------------------
>
> Key: HDFS-7459
> URL: https://issues.apache.org/jira/browse/HDFS-7459
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Haohui Mai
> Assignee: Haohui Mai
> Attachments: HDFS-7459.000.patch, HDFS-7459.001.patch,
> HDFS-7459.002.patch
>
>
> This jira proposes to consolidate cache-related implementation in
> FSNamesystem into a single class.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
