[
https://issues.apache.org/jira/browse/HDFS-5757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14236636#comment-14236636
]
Hadoop QA commented on HDFS-5757:
---------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12685508/HDFS-5757.patch
against trunk revision e227fb8.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:red}-1 findbugs{color}. The patch appears to introduce 1 new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The following test timeouts occurred in
hadoop-hdfs-project/hadoop-hdfs:
org.apache.hadoop.hdfs.server.blockmanagement.TestDatanodeManager
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/8940//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HDFS-Build/8940//artifact/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/8940//console
This message is automatically generated.
> refreshNodes with many nodes at the same time could slow down NN
> ----------------------------------------------------------------
>
> Key: HDFS-5757
> URL: https://issues.apache.org/jira/browse/HDFS-5757
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: namenode
> Reporter: Ming Ma
> Assignee: Ming Ma
> Attachments: HDFS-5757.patch
>
>
> Sometimes we need to decomm a whole rack of nodes at the same time. When the
> decomm is in process; NN is slow.
> The reason is when DecommissionManager checks the decomm status, it acquires
> namesystem's writer lock and iterates through all DNs; for each DN that is in
> decommissioning state, it check if replication is done for all the blocks on
> the machine via blockManager.isReplicationInProgress; for large cluster; the
> number of blocks on the machine could be big.
> The fix could be to have DecommissionManager check for several
> decomm-in-progress nodes each time it aquires namesystem's writer lock.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
