[
https://issues.apache.org/jira/browse/HDFS-7498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14239309#comment-14239309
]
Hadoop QA commented on HDFS-7498:
---------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12685961/HDFS-7498.000.patch
against trunk revision db73cc9.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:red}-1 findbugs{color}. The patch appears to introduce 352 new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests in
hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs:
org.apache.hadoop.hdfs.server.datanode.TestMultipleNNDataBlockScanner
org.apache.hadoop.hdfs.server.namenode.snapshot.TestRenameWithSnapshots
The following test timeouts occurred in
hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs:
org.apache.hadoop.fs.viewfs.TestViewFileSystemLocalFileSystem
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/8967//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HDFS-Build/8967//artifact/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HDFS-Build/8967//artifact/patchprocess/newPatchFindbugsWarningshadoop-common.html
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/8967//console
This message is automatically generated.
> Simplify the logic in INodesInPath
> ----------------------------------
>
> Key: HDFS-7498
> URL: https://issues.apache.org/jira/browse/HDFS-7498
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: namenode
> Reporter: Jing Zhao
> Assignee: Jing Zhao
> Attachments: HDFS-7498.000.patch
>
>
> Currently we have relatively complicated logic in INodesInPath:
> 1) It can contain null elements in its INode array, and in
> {{mkdirRecursively}} these null INodes are replaced with new directories.
> 2) Operations like rename may also replace the inode in its INode array
> 3) {{getINodes}} requires trimming inodes array if the INodesInPath is
> derived from a dot-snapshot path
> 4) A lot of methods directly use/manipulate its INode array
> We aim to simplify the logic of INodesInPath in this jira. Specifically, we
> can
> make INodesInPath an immutable data structure and move the inode trimming
> logic to path resolving.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
