[
https://issues.apache.org/jira/browse/HDFS-7449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14241834#comment-14241834
]
Yongjun Zhang commented on HDFS-7449:
-------------------------------------
HI [~brandonli],
Thanks for working on this, definitely a good thing to have!
I have a couple of comments here,
* suggest to create a method to wrap {{System.nanoTime() - startTime}} in
RpcProgramNfs3, and replaces the quite a few places with a call to this method.
* along the line that [~wheat9] commented, seems that {{RpcInfo.channel}}, {{
rpcCall.getXid()}} are very common parameters across the board, possibly they
could be wrapped in a {{HandlerCtx}} class. And then the startTime can be
included in this context. It would help avoiding changing API next time when we
need to add additional stuff to this context. I wonder if this makes sense to
you.
Thanks.
> Add metrics to NFS gateway
> --------------------------
>
> Key: HDFS-7449
> URL: https://issues.apache.org/jira/browse/HDFS-7449
> Project: Hadoop HDFS
> Issue Type: New Feature
> Components: nfs
> Affects Versions: 2.7.0
> Reporter: Brandon Li
> Assignee: Brandon Li
> Attachments: HDFS-7449.001.patch, HDFS-7449.002.patch,
> HDFS-7449.003.patch, HDFS-7449.004.patch, HDFS-7449.005.patch,
> HDFS-7449.006.patch
>
>
> Add metrics to collect the NFSv3 handler operations, response time and etc.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
