[
https://issues.apache.org/jira/browse/HDFS-7463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14243848#comment-14243848
]
Andrew Wang commented on HDFS-7463:
-----------------------------------
I think this introduced a findbugs warning in getBlockLocations, see this:
https://builds.apache.org/job/PreCommit-HDFS-Build/9019//artifact/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html
> Simplify FSNamesystem#getBlockLocationsUpdateTimes
> --------------------------------------------------
>
> Key: HDFS-7463
> URL: https://issues.apache.org/jira/browse/HDFS-7463
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: Haohui Mai
> Assignee: Haohui Mai
> Fix For: 2.7.0
>
> Attachments: HDFS-7463.000.patch, HDFS-7463.001.patch,
> HDFS-7463.002.patch, HDFS-7463.003.patch, HDFS-7463.004.patch,
> HDFS-7463.005.patch, HDFS-7463.006.patch, HDFS-7463.007.patch,
> HDFS-7463.008.patch, HDFS-7463.008.patch
>
>
> Currently {{FSNamesystem#getBlockLocationsUpdateTimes}} holds the read lock
> to access the blocks. It releases the read lock and then acquires the write
> lock when it needs to update the access time of the {{INode}}.
> This jira proposes to move the responsibility of the latter steps to the
> caller to simplify the code.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
