[
https://issues.apache.org/jira/browse/HDFS-7516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14245231#comment-14245231
]
Haohui Mai commented on HDFS-7516:
----------------------------------
The patch looks good. A nit:
{code}
- byte[] in = s.getBytes();
+ byte[] in = s.getBytes(Charsets.UTF_8);
for (int i = 0; i < in.length; i++) {
digest.update(in[i]);
}
{code}
You can do:
{code}
digest.update(s.getBytes(Charsets.UTF_8));
{code}
+1 after addressing it.
> Fix findbugs warnings in hdfs-nfs project
> -----------------------------------------
>
> Key: HDFS-7516
> URL: https://issues.apache.org/jira/browse/HDFS-7516
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: nfs
> Affects Versions: 2.7.0
> Reporter: Brandon Li
> Assignee: Brandon Li
> Attachments: HDFS-7516.001.patch, findbugsXml.xml
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
