[ 
https://issues.apache.org/jira/browse/HDFS-7531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14250828#comment-14250828
 ] 

Hadoop QA commented on HDFS-7531:
---------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12687810/HDFS-7531.002.patch
  against trunk revision f2d150e.

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:green}+1 tests included{color}.  The patch appears to include 1 new 
or modified test files.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with 
eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

    {color:red}-1 core tests{color}.  The patch failed these unit tests in 
hadoop-hdfs-project/hadoop-hdfs:

                  
org.apache.hadoop.hdfs.server.blockmanagement.TestDatanodeManager
                  
org.apache.hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureToleration

Test results: 
https://builds.apache.org/job/PreCommit-HDFS-Build/9061//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/9061//console

This message is automatically generated.

> Improve the concurrent access on FsVolumeList
> ---------------------------------------------
>
>                 Key: HDFS-7531
>                 URL: https://issues.apache.org/jira/browse/HDFS-7531
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: datanode
>    Affects Versions: 2.6.0
>            Reporter: Lei (Eddy) Xu
>            Assignee: Lei (Eddy) Xu
>         Attachments: HDFS-7531.000.patch, HDFS-7531.001.patch, 
> HDFS-7531.002.patch
>
>
> {{FsVolumeList}} uses {{synchronized}} to protect the update on 
> {{FsVolumeList#volumes}}, while various operations (e.g., {{checkDirs()}}, 
> {{getAvailable()}}) iterate {{volumes}} without protection.
> This JIRA proposes to use {{AtomicReference}} to encapture {{volumes}} to 
> provide better concurrent access.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to