[
https://issues.apache.org/jira/browse/HDFS-7543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14252209#comment-14252209
]
Charles Lamb commented on HDFS-7543:
------------------------------------
Sorry I'm late to the party. Here are a few comments:
FSDirMkdirOp.java
in #mkdirs, you removed the final String srcArg = src. This should be left in.
Many IDEs will whine about making assignments to formal args and that's why it
was put in in the first place.
FSDirRenameOp.java
#renameToInt, dstIIP (and resultingStat) could benefit from final's.
FSDirXAttrOp.java
I'm not sure why you've moved the call to getINodesInPath4Write and
checkXAttrChangeAccess inside the writeLock.
FSDirStatAndListing.java
The javadoc for the @param src needs to be changed to reflect that it's an
INodesInPath, not a String. Nit: it might be better to rename the INodesInPath
arg from src to iip.
#getFileInfo4DotSnapshot is now unused since you in-lined it into #getFileInfo.
> Avoid path resolution when getting FileStatus for audit logs
> ------------------------------------------------------------
>
> Key: HDFS-7543
> URL: https://issues.apache.org/jira/browse/HDFS-7543
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Haohui Mai
> Assignee: Haohui Mai
> Fix For: 2.7.0
>
> Attachments: HDFS-7543.000.patch
>
>
> The current API of {{getAuditFileInfo()}} forces parsing the paths again when
> generating the {{HdfsFileStatus}} for audit logs. This jira proposes to
> avoid the repeated parsing by passing the {{INodesInPath}} object instead of
> the path.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
