[
https://issues.apache.org/jira/browse/HDFS-7551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14252868#comment-14252868
]
Akira AJISAKA commented on HDFS-7551:
-------------------------------------
[~xieliang007] thanks for the report and the patch. Minor comments:
{code}
+ if (!success) {
+ LOG.warn("Failed to delete tmp file:" + file.getAbsolutePath());
+ }
{code}
1. Would you fix the indent size to 2 spaces instead of 4?
2. Would you add a whitespace to log after "file:" ?
The rest looks good to me.
> Fix the new findbugs warning from TransferFsImage
> -------------------------------------------------
>
> Key: HDFS-7551
> URL: https://issues.apache.org/jira/browse/HDFS-7551
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: namenode
> Affects Versions: 2.7.0
> Reporter: Liang Xie
> Assignee: Liang Xie
> Priority: Minor
> Attachments: HDFS-7551-001.txt
>
>
> seems to me it came from https://issues.apache.org/jira/browse/HDFS-7373's
> change
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
