[jira] [Commented] (HDFS-7578) NFS WRITE and COMMIT responses should always use the channel pipeline

[Charles Lamb (JIRA)]

    [ 
https://issues.apache.org/jira/browse/HDFS-7578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14261485#comment-14261485
 ] 

Charles Lamb commented on HDFS-7578:
------------------------------------

Hi [~brandonli],

Thanks for posting this patch. It looks pretty good. Did you see this problem 
in the field or did you notice it through code examination? Is it possible to 
create an actual test case the demonstrates the problem?

I have a few relatively minor comments.

In Nfs3Utils.java, you could change this:

{code}
    XDR out = new XDR();
    out = response.serialize(out, xid, new VerifierNone());
{code}

to

{code}
    final XDR out = response.serialize(new XDR(), xid, new VerifierNone());
{code}

Also, the code in #writeChannelCommit and #writeChannel are pretty much 
identical except for the call to LOG.debug. You might want to refactor that a 
little. (also, s/Commit done:/Commit done: /)

Thanks.
Charles



> NFS WRITE and COMMIT responses should always use the channel pipeline
> ---------------------------------------------------------------------
>
>                 Key: HDFS-7578
>                 URL: https://issues.apache.org/jira/browse/HDFS-7578
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: nfs
>    Affects Versions: 2.7.0
>            Reporter: Brandon Li
>            Assignee: Brandon Li
>         Attachments: HDFS-7578.001.patch
>
>
> Write and Commit responses directly write data to the channel instead of 
> pushing it to the channel pipeline. This could block the NFS handler thread 
> waiting for the response to be flushed to the network before it can return to 
> serve a different request.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)