[
https://issues.apache.org/jira/browse/HDFS-5631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14267241#comment-14267241
]
Tsz Wo Nicholas Sze commented on HDFS-5631:
-------------------------------------------
Changing ChunkChecksum and BlockMetadataHeader's readHeader() and writeHeader()
to public sound good.
For the test, how would someone add new methods to FsDatasetSpi or change the
existing methods? Are they supposed to update the test at the same time?
> Expose interfaces required by FsDatasetSpi implementations
> ----------------------------------------------------------
>
> Key: HDFS-5631
> URL: https://issues.apache.org/jira/browse/HDFS-5631
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: datanode
> Affects Versions: 3.0.0
> Reporter: David Powell
> Assignee: David Powell
> Priority: Minor
> Attachments: HDFS-5631.patch, HDFS-5631.patch
>
>
> This sub-task addresses section 4.1 of the document attached to HDFS-5194,
> the exposure of interfaces needed by a FsDatasetSpi implementation.
> Specifically it makes ChunkChecksum public and BlockMetadataHeader's
> readHeader() and writeHeader() methods public.
> The changes to BlockReaderUtil (and related classes) discussed by section
> 4.1 are only needed if supporting short-circuit, and should be addressed
> as part of an effort to provide such support rather than this JIRA.
> To help ensure these changes are complete and are not regressed in the
> future, tests that gauge the accessibility (though *not* behavior)
> of interfaces needed by a FsDatasetSpi subclass are also included.
> These take the form of a dummy FsDatasetSpi subclass -- a successful
> compilation is effectively a pass. Trivial unit tests are included so
> that there is something tangible to track.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
