[
https://issues.apache.org/jira/browse/HDFS-7589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14268439#comment-14268439
]
Chris Nauroth commented on HDFS-7589:
-------------------------------------
Hello [~wangzw]. This looks mostly good. Thank you for the patch.
There is a compilation error on Windows in test_libhdfs_zerocopy.c in
{{nmdConfigureHdfsBuilder}}. We have to stick to the C89 rules for declaring
local variables at the top of the function, but {{domainSocket}} is declared
midway through the function. In this case, you can fix it by moving the line
declaring and initializing {{domainSocket}} to the top like this:
{code}
int ret;
tPort port;
const char *domainSocket = hdfsGetDomainSocketPath(cl);
{code}
If you want to remove the dependency on hdfs.h, I don't think it would be a bad
thing to duplicate the definition of {{EINTERNAL}} here.
This patch is not dependent on anything in the HDFS-6994 feature branch, so I
think we can target this straight to trunk and branch-2. That would reduce the
size of the patch for reviewers to check later when it comes time for a merge
of the feature branch back to trunk. Let me know your thoughts. If you agree,
please click the Submit Patch button to trigger a Jenkins run.
> Break the dependency between libnative_mini_dfs and libhdfs
> -----------------------------------------------------------
>
> Key: HDFS-7589
> URL: https://issues.apache.org/jira/browse/HDFS-7589
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: hdfs-client
> Reporter: Zhanwei Wang
> Assignee: Zhanwei Wang
> Attachments: HDFS-7589.patch
>
>
> Currently libnative_mini_dfs links with libhdfs to reuse some common code.
> Other applications which want to use libnative_mini_dfs have to link to
> libhdfs.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
