[
https://issues.apache.org/jira/browse/HDFS-7577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14285057#comment-14285057
]
Colin Patrick McCabe commented on HDFS-7577:
--------------------------------------------
This looks pretty good.
{{os/windows/cpuid.h}}: this is x86-specific, right? Can we put this in an x86
ifdef like the one from HWCrc32c.cc?
Something like this maybe:
{code}
#if ((defined(__X86__) || defined(__i386__) || defined(i386) ||
defined(_M_IX86) || defined(__386__) || defined(__x86_64__) || defined(_M_X64)))
{code}
> Add additional headers that includes need by Windows
> ----------------------------------------------------
>
> Key: HDFS-7577
> URL: https://issues.apache.org/jira/browse/HDFS-7577
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: hdfs-client
> Reporter: Thanh Do
> Assignee: Thanh Do
> Attachments: HDFS-7577-branch-HDFS-6994-0.patch
>
>
> This jira involves adding a list of (mostly dummy) headers that available in
> POSIX systems, but not in Windows. One step towards making libhdfs3 built in
> Windows.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
