[ https://issues.apache.org/jira/browse/HDFS-3689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14285063#comment-14285063 ]
Colin Patrick McCabe commented on HDFS-3689: -------------------------------------------- Thanks for working on this, Jing. {code} 320 public FSDataOutputStream append(Path f, final boolean toNewBlock, 321 final int bufferSize, final Progressable progress) throws IOException { {code} Let's make {{toNewBlock}} a {{CreateFlag}} and create a new append function that takes an {{EnumSet}} of {{CreateFlag}}. We talked about this earlier and the combinatorial explosion of {{FileSystem}} overloaded functions is a real problem, which the {{CreateFlag}} strategy solves really well. This also makes it easy to use the feature via {{FileContext}}. Also, are you targetting this for 3.0 or for a 2.x release? > Add support for variable length block > ------------------------------------- > > Key: HDFS-3689 > URL: https://issues.apache.org/jira/browse/HDFS-3689 > Project: Hadoop HDFS > Issue Type: New Feature > Components: datanode, hdfs-client, namenode > Affects Versions: 3.0.0 > Reporter: Suresh Srinivas > Assignee: Jing Zhao > Attachments: HDFS-3689.000.patch, HDFS-3689.001.patch, > HDFS-3689.002.patch, HDFS-3689.003.patch, HDFS-3689.003.patch, > HDFS-3689.004.patch, HDFS-3689.005.patch, HDFS-3689.006.patch, > HDFS-3689.007.patch > > > Currently HDFS supports fixed length blocks. Supporting variable length block > will allow new use cases and features to be built on top of HDFS. -- This message was sent by Atlassian JIRA (v6.3.4#6332)