[ 
https://issues.apache.org/jira/browse/HDFS-7675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14292308#comment-14292308
 ] 

Colin Patrick McCabe commented on HDFS-7675:
--------------------------------------------

It's not redundant.  Calling {{SpanReceiverHost#getInstance}} initializes 
{{SpanReceiverHost#SingletonHolder#INSTANCE}}, which is needed for tracing to 
operate.  This code was taken from HBase, which has a similar construct for 
tracing.

I agree that we could probably skip storing the {{SpanReceiverHost}} inside 
{{DFSClient}}, as long as there was a comment about why we were calling 
{{getInstance}}.

> Unused member DFSClient.spanReceiverHost
> ----------------------------------------
>
>                 Key: HDFS-7675
>                 URL: https://issues.apache.org/jira/browse/HDFS-7675
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: dfsclient
>    Affects Versions: 3.0.0
>            Reporter: Konstantin Shvachko
>
> DFSClient.spanReceiverHost is initialised but never used. Could be redundant.
> This was introduced by HDFS-7055.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to