[
https://issues.apache.org/jira/browse/HDFS-7584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14293051#comment-14293051
]
Xiaoyu Yao commented on HDFS-7584:
----------------------------------
Thanks Arpit again for the feedback. I've fixed your comments 1,2,5.
bq. Just an observation, and you don't really need to fix it. I realize you are
trying to avoid a new RPC call by modifying the existing
ClientProtocol.setQuota call. But it does create a confusing difference between
that and DFSClient.setQuota which has two overloads and the matching overload
of DFSClient.setQuota behaves differently (throws exception on null). Perhaps
it is better to add a new ClientProtocol.setQuota RPC call. Either is fine
though.
The decision to reuse existing setQuota RPC call compatibly instead of adding a
new one is based on the feedbacks from design review. The API that throws
exception on null storage type is the new API DFSClient#setQuotaByStorageType
with a different signature. We keep the original DFSClient#setQuota(dsQuota,
nsQuota) as-is so that it won't break existing clients. With a single setQuota
RPC message, I think it should be fine.
bq. Do we need the new config key DFS_QUOTA_BY_STORAGETYPE_ENABLED_KEY? The
administrator can already choose to avoid configuring per-type quotas so I am
not sure the new configuration is useful.
Adding the key allow us to completely disable the feature. Without the key, the
admin can accidentally configure and enable this feature. I can remove it if
this is not needed.
> Enable Quota Support for Storage Types
> --------------------------------------
>
> Key: HDFS-7584
> URL: https://issues.apache.org/jira/browse/HDFS-7584
> Project: Hadoop HDFS
> Issue Type: New Feature
> Components: datanode, namenode
> Reporter: Xiaoyu Yao
> Assignee: Xiaoyu Yao
> Attachments: HDFS-7584 Quota by Storage Type - 01202015.pdf,
> HDFS-7584.0.patch, HDFS-7584.1.patch, HDFS-7584.2.patch, HDFS-7584.3.patch,
> HDFS-7584.4.patch, editsStored
>
>
> Phase II of the Heterogeneous storage features have completed by HDFS-6584.
> This JIRA is opened to enable Quota support of different storage types in
> terms of storage space usage. This is more important for certain storage
> types such as SSD as it is precious and more performant.
> As described in the design doc of HDFS-5682, we plan to add new
> quotaByStorageType command and new name node RPC protocol for it. The quota
> by storage type feature is applied to HDFS directory level similar to
> traditional HDFS space quota.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
