[
https://issues.apache.org/jira/browse/HDFS-7681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14296090#comment-14296090
]
Tsz Wo Nicholas Sze commented on HDFS-7681:
-------------------------------------------
The failure of TestBalancer is not related to this.
During reviewing the patch, I found that getTmpInputStreams(..) may lead file
descriptors in case of exceptions. Will file a JIRA for following up.
+1 patch looks good.
> Fix ReplicaInputStream constructor to take InputStreams
> -------------------------------------------------------
>
> Key: HDFS-7681
> URL: https://issues.apache.org/jira/browse/HDFS-7681
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: datanode
> Affects Versions: 3.0.0
> Reporter: Joe Pallas
> Assignee: Joe Pallas
> Attachments: HDFS-7681.patch
>
>
> As noted in HDFS-5194, the constructor for {{ReplicaInputStream}} takes
> {{FileDescriptor}} s that are immediately turned into {{InputStream}} s,
> while the callers already have {{FileInputStream}} s from which they extract
> {{FileDescriptor}} s. This seems to have been done as part of a large set of
> changes to appease findbugs.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
