[ 
https://issues.apache.org/jira/browse/HDFS-7703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14298433#comment-14298433
 ] 

Rakesh R commented on HDFS-7703:
--------------------------------

Nice patch!

Just one comment, javadoc is missing.

{code}
DistributedFileSystem.java

+  public FSDataOutputStream append(Path f, final EnumSet<CreateFlag> flag,
+      final int bufferSize, final Progressable progress,
+      final InetSocketAddress[] favoredNodes) throws IOException {
{code}

> Support favouredNodes for the append for new blocks
> ---------------------------------------------------
>
>                 Key: HDFS-7703
>                 URL: https://issues.apache.org/jira/browse/HDFS-7703
>             Project: Hadoop HDFS
>          Issue Type: Bug
>    Affects Versions: 2.6.0
>            Reporter: Vinayakumar B
>            Assignee: Vinayakumar B
>         Attachments: HDFS-7703-001.patch
>
>
> Currently favorNodes is supported for the new file creation, and these nodes 
> are applicable for all blocks of the file.
> Same support should be available when file is opened for append.
> But, even though original file has not used favor nodes, favorNodes passed to 
> append will be used only for new blocks.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to