[
https://issues.apache.org/jira/browse/HDFS-7721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14302288#comment-14302288
]
Colin Patrick McCabe commented on HDFS-7721:
--------------------------------------------
* Avoid running the scanner fast in the first hour when the VolumeScanner
starts. The reason why it was running fast was because we were looking at the
average I/O over the last hour, and treating minutes before the daemon started
up as minutes when we did no I/O. Instead, we should average only over the
time that the daemon has been up during the first hour.
* Add a more helpful error message to the {{testScanRateLimit}} test.
* Make the {{testScanRateLimit}} test more consistent by waiting for some
blocks to be scanned before waiting and then checking the effective rate. This
will ensure that the volume scanner has started.
> TestBlockScanner.testScanRateLimit may fail
> -------------------------------------------
>
> Key: HDFS-7721
> URL: https://issues.apache.org/jira/browse/HDFS-7721
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: datanode
> Reporter: Tsz Wo Nicholas Sze
> Attachments: HDFS-7721.001.patch
>
>
> -
> https://builds.apache.org/job/PreCommit-HDFS-Build/9375//testReport/org.apache.hadoop.hdfs.server.datanode/TestBlockScanner/testScanRateLimit/
> -
> https://builds.apache.org/job/PreCommit-HDFS-Build/9365//testReport/org.apache.hadoop.hdfs.server.datanode/TestBlockScanner/testScanRateLimit/
> {code}
> java.lang.AssertionError: null
> at org.junit.Assert.fail(Assert.java:86)
> at org.junit.Assert.assertTrue(Assert.java:41)
> at org.junit.Assert.assertTrue(Assert.java:52)
> at
> org.apache.hadoop.hdfs.server.datanode.TestBlockScanner.testScanRateLimit(TestBlockScanner.java:439)
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)