[ https://issues.apache.org/jira/browse/HDFS-7411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14302585#comment-14302585 ]
Tsz Wo Nicholas Sze commented on HDFS-7411: ------------------------------------------- > I think it's pretty common for us to change the behavior of the system when > the behavior change is a strict improvement. Keeping around inferior behavior > just for the purpose of consistency seems rather pointless. First of all, we never have showed that the new behavior is strictly better. It is a hypothesis. No? > For example, it used to be the case that fsimage transfers ... The fsimage transfer change is an internal protocol change. The http interface is not a public API. However, the conf property discussed here is public. > Similarly, when we find ways that CPU performance or memory usage in the NN > can be improved, ... The change here is not like that. It changes the scheme from node based to block based. It is not making the node based decommission faster. > As Andrew Wang has already described, the new behavior should be both more > performant and more predictable. ... As mentioned previously, it is a hypothesis. That why Andrew described as "should be". > Refactor and improve decommissioning logic into DecommissionManager > ------------------------------------------------------------------- > > Key: HDFS-7411 > URL: https://issues.apache.org/jira/browse/HDFS-7411 > Project: Hadoop HDFS > Issue Type: Improvement > Affects Versions: 2.5.1 > Reporter: Andrew Wang > Assignee: Andrew Wang > Attachments: hdfs-7411.001.patch, hdfs-7411.002.patch, > hdfs-7411.003.patch, hdfs-7411.004.patch, hdfs-7411.005.patch, > hdfs-7411.006.patch, hdfs-7411.007.patch, hdfs-7411.008.patch, > hdfs-7411.009.patch, hdfs-7411.010.patch > > > Would be nice to split out decommission logic from DatanodeManager to > DecommissionManager. -- This message was sent by Atlassian JIRA (v6.3.4#6332)