[ 
https://issues.apache.org/jira/browse/HDFS-7728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14302707#comment-14302707
 ] 

Hadoop QA commented on HDFS-7728:
---------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12696062/HDFS-7728.000.patch
  against trunk revision 8cb4731.

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:green}+1 tests included{color}.  The patch appears to include 3 new 
or modified test files.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with 
eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

    {color:red}-1 core tests{color}.  The patch failed these unit tests in 
hadoop-hdfs-project/hadoop-hdfs:

                  org.apache.hadoop.hdfs.server.namenode.ha.TestRetryCacheWithHA
                  org.apache.hadoop.fs.TestHDFSFileContextMainOperations

                                      The following test timeouts occurred in 
hadoop-hdfs-project/hadoop-hdfs:

org.apache.hadoop.hdfs.TestDistributedFileSystem

Test results: 
https://builds.apache.org/job/PreCommit-HDFS-Build/9407//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/9407//console

This message is automatically generated.

> Avoid updating quota usage while loading edits
> ----------------------------------------------
>
>                 Key: HDFS-7728
>                 URL: https://issues.apache.org/jira/browse/HDFS-7728
>             Project: Hadoop HDFS
>          Issue Type: Bug
>            Reporter: Jing Zhao
>            Assignee: Jing Zhao
>         Attachments: HDFS-7728.000.patch
>
>
> Per the discussion 
> [here|https://issues.apache.org/jira/browse/HDFS-7611?focusedCommentId=14292454&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14292454],
>  currently we call {{INode#addSpaceConsumed}} while file/dir/snapshot 
> deletion, even if this is still in the edits loading process. This is 
> unnecessary and can cause issue like HDFS-7611. We should collect quota 
> change and call {{FSDirectory#updateCount}} at the end of the operation.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to