[
https://issues.apache.org/jira/browse/HDFS-7728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14302558#comment-14302558
]
Jing Zhao edited comment on HDFS-7728 at 2/3/15 9:21 PM:
---------------------------------------------------------
The initial patch for review.
The main challenge here is that for an INodeReference instance (along with the
subtree underneath) we have to double count its quota usage. Thus the patch
defines a QuotaDelta class which records quota usage updates along all the
necessary paths, and pass it to {{INode#cleanSubtree}} and
{{INode#destroyAndCollectBlocks}}.
was (Author: jingzhao):
The initial patch for review.
The main challenge here is that for an INodeReference instance (along with the
subtree underneath) we have to double count its quota usage. Thus the patch
defines a QuotaDelta class which contains quota usage updates along all the
necessary paths, and pass it to {{INode#cleanSubtree}} and
{{INode#destroyAndCollectBlocks}}.
> Avoid updating quota usage while loading edits
> ----------------------------------------------
>
> Key: HDFS-7728
> URL: https://issues.apache.org/jira/browse/HDFS-7728
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: Jing Zhao
> Assignee: Jing Zhao
> Attachments: HDFS-7728.000.patch, HDFS-7728.001.patch
>
>
> Per the discussion
> [here|https://issues.apache.org/jira/browse/HDFS-7611?focusedCommentId=14292454&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14292454],
> currently we call {{INode#addSpaceConsumed}} while file/dir/snapshot
> deletion, even if this is still in the edits loading process. This is
> unnecessary and can cause issue like HDFS-7611. We should collect quota
> change and call {{FSDirectory#updateCount}} at the end of the operation.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
