[
https://issues.apache.org/jira/browse/HDFS-7738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14306573#comment-14306573
]
Yi Liu commented on HDFS-7738:
------------------------------
{quote}
I rather keep this patch simple. Sounds good?
{quote}
I'm OK for this. +1.
{quote}
Since AlreadyBeingCreatedException is in org.apache.hadoop.hdfs.protocol,
changing is to something else is a bigger change which need more thought
{quote}
Yes, but actually {{AlreadyBeingCreatedException}} is only explicitly thrown by
{{ClientProtocol#create}} . My thought is we can define a separate recover
lease exception which extends IOException and let
{{AlreadyBeingCreatedException}} extends it, otherwise people may see already
being created exception when he does an append/truncate operation, that's odd.
Of course, it's a minor improvement, we can also do it in a follow-on JIRA if
you think it's necessary.
> Add more negative tests for truncate
> ------------------------------------
>
> Key: HDFS-7738
> URL: https://issues.apache.org/jira/browse/HDFS-7738
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: test
> Reporter: Tsz Wo Nicholas Sze
> Assignee: Tsz Wo Nicholas Sze
> Priority: Minor
> Fix For: 2.7.0
>
> Attachments: h7738_20150204.patch
>
>
> The following are negative test cases for truncate.
> - new length > old length
> - truncating a directory
> - truncating a non-existing file
> - truncating a file without write permission
> - truncating a file opened for append
> - truncating a file in safemode
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
