[
https://issues.apache.org/jira/browse/HDFS-4265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14310554#comment-14310554
]
Akira AJISAKA commented on HDFS-4265:
-------------------------------------
Here are some trivial comments:
* Some inserted lines are over 80 characters.
* There is a trailing whitespace.
{code}
+ * Sleep a bookie until I count down the latch
+ *
+ * @param latch
{code}
* Would you please remove the initial capacity of the list? It's a little
confusing.
{code}
+ private static List<BookieServer> bks = new ArrayList<BookieServer>(4);
{code}
I'm +1 after these are addressed.
> BKJM doesn't take advantage of speculative reads
> ------------------------------------------------
>
> Key: HDFS-4265
> URL: https://issues.apache.org/jira/browse/HDFS-4265
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ha
> Affects Versions: 2.2.0
> Reporter: Ivan Kelly
> Assignee: Rakesh R
> Attachments: 0005-HDFS-4265.patch, 0006-HDFS-4265.patch,
> 0007-HDFS-4265.patch, 001-HDFS-4265.patch, 002-HDFS-4265.patch,
> 003-HDFS-4265.patch, 004-HDFS-4265.patch
>
>
> BookKeeperEditLogInputStream reads entry at a time, so it doesn't take
> advantage of the speculative read mechanism introduced by BOOKKEEPER-336.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
