[
https://issues.apache.org/jira/browse/HDFS-7496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14316761#comment-14316761
]
Chris Nauroth commented on HDFS-7496:
-------------------------------------
The trunk commit for this patch (git hash
b7f4a3156c0f5c600816c469637237ba6c9b330c) included a test class named
{{FsVolumeListTest}}. It appears that this class was not included in the
cherry-pick to branch-2 (git hash 5ec2b6caa9d63123a88f407f734319d4ac6038a9).
Can one of the original contributors or reviewers please clarify whether or not
this class was intended to be committed? I ask because it's causing a merge
conflict now for HDFS-7604.
Also, if the intention is to keep this class, then it will need to be renamed.
It has not actually been running in pre-commit. That's because our
maven-surefire-plugin configuration in hadoop-project/pom.xml is set to match
only on test classes beginning with "Test" in the name:
{code}
<includes>
<include>**/Test*.java</include>
</includes>
{code}
This is done to prevent the plugin from erroneously trying to run helper
classes under src/test/java as if they were JUnit suites.
> Fix FsVolume removal race conditions on the DataNode by reference-counting
> the volume instances
> -----------------------------------------------------------------------------------------------
>
> Key: HDFS-7496
> URL: https://issues.apache.org/jira/browse/HDFS-7496
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: Colin Patrick McCabe
> Assignee: Lei (Eddy) Xu
> Fix For: 2.7.0
>
> Attachments: HDFS-7496-branch-2.000.patch, HDFS-7496.000.patch,
> HDFS-7496.001.patch, HDFS-7496.002.patch, HDFS-7496.003.patch,
> HDFS-7496.003.patch, HDFS-7496.004.patch, HDFS-7496.005.patch,
> HDFS-7496.006.patch, HDFS-7496.007.patch
>
>
> We discussed a few FsVolume removal race conditions on the DataNode in
> HDFS-7489. We should figure out a way to make removing an FsVolume safe.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
