[
https://issues.apache.org/jira/browse/HDFS-7411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14316965#comment-14316965
]
Andrew Wang commented on HDFS-7411:
-----------------------------------
bq. Andrew, even though you prefer estimates or averages that approximate the
existing behavior, halting when either of the limits are hit would move this
forward.
Saying to "use the node limit" is underspecified, since the new code only
iterates over decomming nodes, whereas the old code iterates over all nodes.
This constitutes a major behavior change, but Nicholas said that iterating over
non-decomming nodes is a bug that should be fixed.
This is why I've been trying to elevate the discussion to what constitutes good
or bad user experience. I have a hard time understanding why the iterating over
just decomming nodes is an allowable change (even though it'll have a huge
affect on pause times and decom rate), but the rest of my proposals are not
okay because they constitute a "behavior change".
> Refactor and improve decommissioning logic into DecommissionManager
> -------------------------------------------------------------------
>
> Key: HDFS-7411
> URL: https://issues.apache.org/jira/browse/HDFS-7411
> Project: Hadoop HDFS
> Issue Type: Improvement
> Affects Versions: 2.5.1
> Reporter: Andrew Wang
> Assignee: Andrew Wang
> Attachments: hdfs-7411.001.patch, hdfs-7411.002.patch,
> hdfs-7411.003.patch, hdfs-7411.004.patch, hdfs-7411.005.patch,
> hdfs-7411.006.patch, hdfs-7411.007.patch, hdfs-7411.008.patch,
> hdfs-7411.009.patch, hdfs-7411.010.patch
>
>
> Would be nice to split out decommission logic from DatanodeManager to
> DecommissionManager.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
