[
https://issues.apache.org/jira/browse/HDFS-7773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14321595#comment-14321595
]
Chris Nauroth commented on HDFS-7773:
-------------------------------------
Hi, Anu. This looks good. I have just a few minor comments:
# {{DataXceiver}}: There is a new local variable named {{size}}. However, I
think this always ends up with the same value as the existing local variable
{{read}}. I suggest declaring {{long read = 0;}} in the outer scope instead of
introducing a new variable.
# {{NameNodeMetrics}}: There are 2 lines of additional whitespace unrelated to
{{totalFileOps}}. I suggest removing those from the patch.
# {{TestNameNodeMetrics}}: Please check the formatting and indentation in this
part of the patch.
Thanks!
> Additional metrics in HDFS to be accessed via jmx.
> --------------------------------------------------
>
> Key: HDFS-7773
> URL: https://issues.apache.org/jira/browse/HDFS-7773
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: datanode, namenode
> Reporter: Anu Engineer
> Assignee: Anu Engineer
> Attachments: hdfs-7773.001.patch
>
>
> We would like to have the following metrics added to DataNode and name node
> this to improve Ambari dashboard
> 1) DN disk i/o utilization
> 2) DN network i/o utilization
> 3) Namenode read operations
> 4) Namenode write operations
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
