[
https://issues.apache.org/jira/browse/HDFS-7808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14326687#comment-14326687
]
Hadoop QA commented on HDFS-7808:
---------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12699523/HDFS-7808-1.patch
against trunk revision 4981d08.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 2 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests in
hadoop-hdfs-project/hadoop-hdfs:
org.apache.hadoop.hdfs.tools.TestDFSHAAdminMiniCluster
Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/9611//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/9611//console
This message is automatically generated.
> Unused code in DFSHAAdmin.java
> ------------------------------
>
> Key: HDFS-7808
> URL: https://issues.apache.org/jira/browse/HDFS-7808
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: Arshad Mohammad
> Assignee: Arshad Mohammad
> Priority: Minor
> Attachments: HDFS-7808-1.patch
>
>
> After HDFS-7324 fix following piece of code become unused. It should be
> removed.
> {code}
> int i = 0;
> String cmd = argv[i++];
> if ("-ns".equals(cmd)) {
> if (i == argv.length) {
> errOut.println("Missing nameservice ID");
> printUsage(errOut);
> return -1;
> }
> nameserviceId = argv[i++];
> if (i >= argv.length) {
> errOut.println("Missing command");
> printUsage(errOut);
> return -1;
> }
> argv = Arrays.copyOfRange(argv, i, argv.length);
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
