[
https://issues.apache.org/jira/browse/HDFS-7467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14333138#comment-14333138
]
Tsz Wo Nicholas Sze commented on HDFS-7467:
-------------------------------------------
The patch looks good. Just some minor comments:
- In StoragePolicySummary.process(), when allBlocksFollowPolicy is set to
false, it can return immediately.
- Need to fix StorageType import. It was moved to fs.StorageType.
- Add @Overreide tag for hashCode(), equals(Object another) and toString().
- StorageTypeAllocation.getStorageAllocationAsString(Map<StorageType, Integer>
storageType_countmap) should be static.
- The indentation for StorageTypeAllocation.getStorageAllocationAsString() is
off. The for-loop is indented too deep.
> Provide storage tier information for a directory via fsck
> ---------------------------------------------------------
>
> Key: HDFS-7467
> URL: https://issues.apache.org/jira/browse/HDFS-7467
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: balancer & mover
> Affects Versions: 2.6.0
> Reporter: Benoy Antony
> Assignee: Benoy Antony
> Attachments: HDFS-7467-002.patch, HDFS-7467-003.patch,
> HDFS-7467.patch, storagepolicydisplay.pdf
>
>
> Currently _fsck_ provides information regarding blocks for a directory.
> It should be augmented to provide storage tier information (optionally).
> The sample report could be as follows :
> {code}
> Storage Tier Combination # of blocks % of blocks
> DISK:1,ARCHIVE:2 340730 97.7393%
>
> ARCHIVE:3 3928 1.1268%
>
> DISK:2,ARCHIVE:2 3122 0.8956%
>
> DISK:2,ARCHIVE:1 748 0.2146%
>
> DISK:1,ARCHIVE:3 44 0.0126%
>
> DISK:3,ARCHIVE:2 30 0.0086%
>
> DISK:3,ARCHIVE:1 9 0.0026%
> {code}
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
