[
https://issues.apache.org/jira/browse/HDFS-7713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14334054#comment-14334054
]
Haohui Mai commented on HDFS-7713:
----------------------------------
Thanks for updating the patch. There are still a lot of unnecessary changes in
the patch. For example:
{code}
- <a href="#" class="dropdown-toggle" data-toggle="dropdown">Utilities
<b class="caret"></b></a>
+ <a href="#" class="dropdown-toggle" data-toggle="dropdown">Utilities
<b class="caret caret-white"></b></a>
{code}
{code}
- <div class="modal" id="file-info" tabindex="-1" role="dialog"
aria-hidden="true">
- <div class="modal-dialog">
- <div class="modal-content">
- <div class="modal-header"><button type="button" class="close"
data-dismiss="modal" aria-hidden="true">×</button>
- <h4 class="modal-title" id="file-info-title">File information</h4>
- </div>
- <div class="modal-body" id="file-info-body">
- <a id="file-info-download">Download</a>
- <!--<a id="file-info-preview" style="cursor:pointer">Tail the file
(last 32K)</a>-->
- <hr />
- <div class="panel panel-success" id="file-info-blockinfo-panel">
- <div class="panel-heading">
- Block information --
- <select class="btn btn-default" id="file-info-blockinfo-list">
- </select>
- </div>
- <div class="panel-body" id="file-info-blockinfo-body"></div>
- </div>
- <div class="panel panel-info" id="file-info-tail"
style="display:none">
- <div class="panel-heading">File contents</div>
- <div class="panel-body">
- <div class="input-group-sm">
- <textarea class="form-control" style="height: 150px"
id="file-info-preview-body"></textarea>
- </div>
- </div>
- </div>
- </div>
- <div class="modal-footer"><button type="button" class="btn
btn-success"
-
data-dismiss="modal">Close</button></div>
- </div>
+
+ <div class="modal" id="file-info" tabindex="-1" role="dialog"
aria-hidden="true">
+ <div class="modal-dialog">
+ <div class="modal-content">
+ <div class="modal-header">
+ <button type="button" class="close" data-dismiss="modal"
aria-hidden="true">×</button>
+ <h4 class="modal-title" id="file-info-title">File information</h4>
+ </div>
+ <div class="modal-body" id="file-info-body">
+ <a id="file-info-download">Download</a>
+ <!--<a id="file-info-preview" style="cursor:pointer">Tail the file
(last 32K)</a>-->
+ <hr/>
+ <div class="panel panel-success" id="file-info-blockinfo-panel">
+ <div class="panel-heading">
+ Block information --
+ <select class="btn btn-default" id="file-info-blockinfo-list">
+ </select>
+ </div>
+ <div class="panel-body" id="file-info-blockinfo-body"></div>
+ </div>
+ <div class="panel panel-info" id="file-info-tail"
style="display:none">
+ <div class="panel-heading">File contents</div>
+ <div class="panel-body">
+ <div class="input-group-sm">
+ <textarea class="form-control" style="height: 150px"
id="file-info-preview-body"></textarea>
+ </div>
+ </div>
+ </div>
+ </div>
+ <div class="modal-footer">
+ <button type="button" class="btn btn-success"
data-dismiss="modal">Close</button>
+ </div>
{code}
....
{code}
- <div class="row">
- <hr />
- <div class="col-xs-2"><p>Hadoop, 2014.</p></div>
+ <div class="row">
+ <div class="col-12">
+ <div id="panel"></div>
</div>
+ </div>
+ <div class="row">
+ <hr />
+ <div class="col-xs-2"><p>Hadoop, 2014.</p></div>
</div>
{code}
There are more throughout the patch. For example, I also think that the changes
to the CSS is unnecessary.
I'll separate the feedbacks of the functionality in a new comment.
> Improve the HDFS Web UI browser to allow creating dirs
> ------------------------------------------------------
>
> Key: HDFS-7713
> URL: https://issues.apache.org/jira/browse/HDFS-7713
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Ravi Prakash
> Assignee: Ravi Prakash
> Attachments: HDFS-7713.01.patch, HDFS-7713.02.patch,
> HDFS-7713.03.patch, HDFS-7713.04.patch
>
>
> This sub-task JIRA is for improving the NN HTML5 UI to allow the user to
> create directories. It uses WebHDFS and adds to the great work done in
> HDFS-6252
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
