[
https://issues.apache.org/jira/browse/HDFS-7495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14335809#comment-14335809
]
Yi Liu commented on HDFS-7495:
------------------------------
Good catch.
+1 for the latest patch. Thanks Ted and Colin.
> Remove updatePosition argument from DFSInputStream#getBlockAt()
> ---------------------------------------------------------------
>
> Key: HDFS-7495
> URL: https://issues.apache.org/jira/browse/HDFS-7495
> Project: Hadoop HDFS
> Issue Type: Bug
> Affects Versions: 2.7.0
> Reporter: Ted Yu
> Assignee: Colin Patrick McCabe
> Priority: Minor
> Attachments: HDFS-7495.002.patch, hdfs-7495-001.patch
>
>
> There're two locks: one on DFSInputStream.this , one on
> DFSInputStream.infoLock
> Normally lock is obtained on infoLock, then on DFSInputStream.infoLock
> However, such order is not observed in DFSInputStream#getBlockAt() :
> {code}
> synchronized(infoLock) {
> ...
> if (updatePosition) {
> // synchronized not strictly needed, since we only get here
> // from synchronized caller methods
> synchronized(this) {
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
