[ 
https://issues.apache.org/jira/browse/HDFS-7817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14337235#comment-14337235
 ] 

Colin Patrick McCabe commented on HDFS-7817:
--------------------------------------------

That's one approach.  Another approach is to force a standards-compliant 
strerror_r to be used by including special #ifdefs at the top of the file using 
strerror_r.  Since sys_errlist is deprecated, that might be the better way.

> libhdfs3: fix strerror_r detection
> ----------------------------------
>
>                 Key: HDFS-7817
>                 URL: https://issues.apache.org/jira/browse/HDFS-7817
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: hdfs-client
>            Reporter: Colin Patrick McCabe
>
> The signature of strerror_r is not quite detected correctly in libhdfs3.  The 
> code assumes that {{int foo = strerror_r}} will fail to compile with the GNU 
> type signature, but this is not the case (C\+\+ will coerce the char* to an 
> int in this case).  Instead, we should do what the libhdfs {{terror}} 
> (threaded error) function does here.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to