[
https://issues.apache.org/jira/browse/HDFS-7749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14337347#comment-14337347
]
Zhe Zhang commented on HDFS-7749:
---------------------------------
The rest of the patch looks good to me. Some minor points (except the last one):
# In {{FSImageFormatPBINode}}: {{stripFeature}} should be {{stripeFeature}}
# In {{FileWithStripedBlocksFeature}}: {{size_1}} could use a better name,
maybe just {{oldSize}} and always use {{oldSize - 1}}?
# Should the following Preconditions check in {{INodeFile}} also check
{{isStriped}}?
{code}
+ Preconditions.checkArgument(blocks == null || blocks.length == 0,
+ "The file contains contiguous blocks");
{code}
# Maybe we should extend {{INodeFile#addBlock}} to handle striped blocks in
this JIRA? Is it a simple matter of checking the type of {{newBlock}} and
calling {{FileWithStripedBlocksFeature#addBlock}} if it's striped? This will
allow us to test some basic client requests.
> Erasure Coding: Add striped block support in INodeFile
> ------------------------------------------------------
>
> Key: HDFS-7749
> URL: https://issues.apache.org/jira/browse/HDFS-7749
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Jing Zhao
> Assignee: Jing Zhao
> Attachments: HDFS-7749.000.patch
>
>
> This jira plan to add a new INodeFile feature to store the stripped blocks
> information in case that the INodeFile is erasure coded.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
