[
https://issues.apache.org/jira/browse/HDFS-7312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14344274#comment-14344274
]
Yongjun Zhang commented on HDFS-7312:
-------------------------------------
Hi [~jprosser],
Thanks for your earlier work on this issue.
I did another round of review, and have another round more comments, +1 once
addressed:
# in DistCp.java:
## add an empty line before "NOTE 3" line, to be consistent.
## I original suggested to change {{job}} to {{jobConf}}, now I think it's
better to keep using the original name {{job}}, so to minimize the diffs we
have to introduce for this patch. If needed, we can have a future jira just to
rename to variable name to make it better.
## remove extra empty line 657
# in TestCopyFiles.java:
## add to TestCopyFiles.java an util method {{private static void
addToArgList(List<String> argList, final String... args)}} to add all args to
argList; and use it to replace all places you touched in TestCopyFiles.java
that does {{argList.add(...)}}. This will make the code much more light-weight.
## rename {{addSrcDstToArgs}} to {{addSrcDstToArgList}}
## make {{addSrcDstToArgList}} call {{addToArgList}} with {{srcs}}
## my previous comments at
https://issues.apache.org/jira/browse/HDFS-7312?focusedCommentId=14223234&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14223234
Thanks.
> Update DistCp v1 to optionally not use tmp location (branch-1 only)
> -------------------------------------------------------------------
>
> Key: HDFS-7312
> URL: https://issues.apache.org/jira/browse/HDFS-7312
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: tools
> Affects Versions: 1.2.1
> Reporter: Joseph Prosser
> Assignee: Joseph Prosser
> Priority: Minor
> Attachments: HDFS-7312.001.patch, HDFS-7312.002.patch,
> HDFS-7312.003.patch, HDFS-7312.004.patch, HDFS-7312.005.patch,
> HDFS-7312.006.patch, HDFS-7312.007.patch, HDFS-7312.patch
>
> Original Estimate: 72h
> Remaining Estimate: 72h
>
> DistCp v1 currently copies files to a tmp location and then renames that to
> the specified destination. This can cause performance issues on filesystems
> such as S3. A -skiptmp flag will be added to bypass this step and copy
> directly to the destination. This feature mirrors a similar one added to
> HBase ExportSnapshot
> [HBASE-11119|https://issues.apache.org/jira/browse/HBASE-11119]
> NOTE: This is a branch-1 change only.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
