[
https://issues.apache.org/jira/browse/HDFS-7835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14344356#comment-14344356
]
Yongjun Zhang commented on HDFS-7835:
-------------------------------------
Hi [~zxu],
Thanks for your work on this jira. The patch looks good. Some nits:
# Suggest to change {{unit is ms, the initial delay for locateFollowingBlock,
delay time}} to {{The initial delay (unit is ms) for locateFollowingBlock, the
delay time}}
# There are two variables {{sleeptime}} and {{localTimeOut}} used for this
delay, the former seems a better name for what it is, I think the latter can be
changed the {{sleeptime}} to be more accurate.
# Need to add the config property to hdfs-default.xml.
# I also found some existing ones in DFSConfigKeys.java not put in
hdfs-default.xml, e.g. {{dfs.client.block.write.locateFollowingBlock.retries}}.
This can be fixed with a follow-up jira.
Thanks.
> make initial sleeptime in locateFollowingBlock configurable for DFSClient.
> --------------------------------------------------------------------------
>
> Key: HDFS-7835
> URL: https://issues.apache.org/jira/browse/HDFS-7835
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: dfsclient
> Reporter: zhihai xu
> Assignee: zhihai xu
> Attachments: HDFS-7835.000.patch
>
>
> Make initial sleeptime in locateFollowingBlock configurable for DFSClient.
> Current the sleeptime/localTimeout in locateFollowingBlock/completeFile from
> DFSOutputStream is hard-coded as 400 ms, but retries can be configured by
> "dfs.client.block.write.locateFollowingBlock.retries". We should also make
> the initial sleeptime configurable to give user more flexibility to control
> both retry and delay.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
