[ https://issues.apache.org/jira/browse/HDFS-6565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14344555#comment-14344555 ]
Haohui Mai commented on HDFS-6565: ---------------------------------- Looks pretty good to me. {code} public static List<Token<?>> toTokenList(final Map<?, ?> json) throws IOException { {code} Looks like the function can be deleted. {code} + } catch (IOException e) { + // can not reach here + } {code} Simply make it like: {code} } catch (IOException ignored) { } {code} {code} + final long len = ((Number) m.get("length")).longValue(); {code} There are many changes like this -- it seems that they are unnecessary? > Use jackson instead jetty json in hdfs-client > --------------------------------------------- > > Key: HDFS-6565 > URL: https://issues.apache.org/jira/browse/HDFS-6565 > Project: Hadoop HDFS > Issue Type: Improvement > Reporter: Haohui Mai > Assignee: Akira AJISAKA > Attachments: HDFS-6565-002.patch, HDFS-6565.patch > > > hdfs-client should use Jackson instead of jetty to parse JSON. -- This message was sent by Atlassian JIRA (v6.3.4#6332)