[ 
https://issues.apache.org/jira/browse/HDFS-7885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14349358#comment-14349358
 ] 

Jing Zhao commented on HDFS-7885:
---------------------------------

Thanks for working on this, Nicholas! Looks like the failure was caused by the 
change on the test TestShortCircuitLocalRead:
{code}
java.io.EOFException: End of file reached before reading fully.
       at 
org.apache.hadoop.hdfs.shortcircuit.TestShortCircuitLocalRead.checkFileContent(TestShortCircuitLocalRead.java:167)
     at 
org.apache.hadoop.hdfs.shortcircuit.TestShortCircuitLocalRead.doTestShortCircuitReadImpl(TestShortCircuitLocalRead.java:287)
 at 
org.apache.hadoop.hdfs.shortcircuit.TestShortCircuitLocalRead.doTestShortCircuitRead(TestShortCircuitLocalRead.java:244)
 at 
org.apache.hadoop.hdfs.shortcircuit.TestShortCircuitLocalRead.testReadFromAnOffset(TestShortCircuitLocalRead.java:333)
{code}
I.e., the reader could not read the newly appended data.

Besides, I guess we only need to add extra tests for legacy local reader?

> Datanode should not trust the generation stamp provided by client
> -----------------------------------------------------------------
>
>                 Key: HDFS-7885
>                 URL: https://issues.apache.org/jira/browse/HDFS-7885
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: datanode
>    Affects Versions: 2.2.0
>            Reporter: vitthal (Suhas) Gogate
>            Assignee: Tsz Wo Nicholas Sze
>            Priority: Critical
>         Attachments: h7885_20150305.patch
>
>
> Datanode should not trust the generation stamp provided by client, since it 
> is prefetched and buffered in client, and concurrent append may increase it.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to