[
https://issues.apache.org/jira/browse/HDFS-7827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14355752#comment-14355752
]
Jing Zhao commented on HDFS-7827:
---------------------------------
Hi Hui, the current patch looks good to me. One comment is that we may need to
explicitly record the type of the blocks in the fsimage (e.g., using a byte in
the fsimage to indicate if the file has striped block). Otherwise the offline
image viewer or fsimage loader has no way to identify the correct block type
when reading the block list.
As you mentioned, we also need to add support in offline image viewer. Besides,
though we may not have a use case anymore, it will be more complete to update
the corresponding FSImage Loader code (more specifically,
FImageFormat#loadINode). Note that we need to check the NameNodeLayoutVersion
there.
> Erasure Coding: support striped blocks in non-protobuf fsimage
> --------------------------------------------------------------
>
> Key: HDFS-7827
> URL: https://issues.apache.org/jira/browse/HDFS-7827
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Jing Zhao
> Assignee: Hui Zheng
> Attachments: HDFS-7827.000.patch
>
>
> HDFS-7749 only adds code to persist striped blocks to protobuf-based fsimage.
> We should also add this support to the non-protobuf fsimage since it is still
> used for use cases like offline image processing.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
