[
https://issues.apache.org/jira/browse/HDFS-5356?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Vinayakumar B updated HDFS-5356:
--------------------------------
Comment: was deleted
(was: Hi [~rakeshr], thanks for the patch.
Here are some comments.
Here need to passdown {{deleteDfsDir}}
{code} public void shutdown(boolean deleteDfsDir) {
+ shutdown(false, true);
+ }{code}
I Don't think below change are necessary in TestFileCreation.java.
{code}+ DistributedFileSystem fs1 = null;{code}
in-fact you can remove the original re-assignment code after cluster restart.
That should ideally work as the NameNode restarted with same ports and data. I
have verified ;)
{code}fs = cluster.getFileSystem();{code}
Changes in TestRenameWithSnapshots.java are not at all required as {{hdfs}} is
re-initialized everytime cluster is restarted. Let it close the FS during
shutdown.)
> MiniDFSCluster shoud close all open FileSystems when shutdown()
> ---------------------------------------------------------------
>
> Key: HDFS-5356
> URL: https://issues.apache.org/jira/browse/HDFS-5356
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: test
> Affects Versions: 3.0.0, 2.2.0
> Reporter: haosdent
> Assignee: Rakesh R
> Priority: Critical
> Attachments: HDFS-5356-1.patch, HDFS-5356-2.patch, HDFS-5356-3.patch,
> HDFS-5356-4.patch, HDFS-5356.patch
>
>
> After add some metrics functions to DFSClient, I found that some unit tests
> relates to metrics are failed. Because MiniDFSCluster are never close open
> FileSystems, DFSClients are alive after MiniDFSCluster shutdown(). The
> metrics of DFSClients in DefaultMetricsSystem are still exist and this make
> other unit tests failed.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
