[ 
https://issues.apache.org/jira/browse/HDFS-1157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12899515#action_12899515
 ] 

Konstantin Boudnik commented on HDFS-1157:
------------------------------------------

I have verified that the patch works for current HDFS trunk despite that 
HDFS-1150's patch for trunk was a little different than for y20. So, the patch 
is still valid.

The reason for the modification is as follows: the call to the original 
constructor with two parameters has been replaced with call to the new one 
{noformat}
      return new DataNode(conf, dirs, resources);
{noformat}
While this is a totally compatible change from the Java perspective, one of 
Herriot aspects was bound to the 'call to the constructor with 2 params' and 
has been broken as the result of the change

> Modifications introduced by HDFS-1150 are breaking aspect's bindings
> --------------------------------------------------------------------
>
>                 Key: HDFS-1157
>                 URL: https://issues.apache.org/jira/browse/HDFS-1157
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: test
>    Affects Versions: 0.20.3
>            Reporter: Konstantin Boudnik
>            Assignee: Konstantin Boudnik
>         Attachments: hdfs-1157.patch
>
>
> Modifications introduced by HDFS-1150 to DataNode class brakes the binding of 
> some of Herriot (test framework) bindings. This JIRA is to track the fix.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to