[
https://issues.apache.org/jira/browse/HDFS-7846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14355210#comment-14355210
]
Charles Lamb commented on HDFS-7846:
------------------------------------
Colin, this looks pretty good. A few questions and comments.
Yi mentioned unused imports, but there are also unnecessary
java.lang.{String,ClassCastException} imports.
BlockId.equals: constructing a ClassCastException, and especially the resulting
call to fillInStackTrace, is an expensive way of checking the type. I would
think instanceof is preferred.
Are you planning on doing something with Shard.name in the future?
The indentation of the assignment to htable is off a bit.
Jenkins will ask you this question, but why no unit tests?
> Create off-heap BlocksMap and BlockData structures
> --------------------------------------------------
>
> Key: HDFS-7846
> URL: https://issues.apache.org/jira/browse/HDFS-7846
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Affects Versions: HDFS-7836
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Attachments: HDFS-7846-scl.001.patch
>
>
> Create off-heap BlocksMap, BlockInfo, and DataNodeInfo structures. The
> BlocksMap will use the off-heap hash table.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
