[
https://issues.apache.org/jira/browse/HDFS-7864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14364289#comment-14364289
]
Jing Zhao commented on HDFS-7864:
---------------------------------
Thanks for updating the patch, Rui! Some comments for the latest patch:
# Actually we do not need {{DFS_NAMENODE_STRIPE_MIN_DEFAULT}}. For a striped
block, the minimal safe number should depend on the EC schema of the
individual block (i.e., the number of data blocks of a striped block group).
Therefore we also need to update the logic of {{incrementSafeBlockCount}}.
# There are still multiple places not following the current project code
convention. E.g., we need to put a space after each comma in the function
parameter list.
> Erasure Coding: Update safemode calculation for striped blocks
> --------------------------------------------------------------
>
> Key: HDFS-7864
> URL: https://issues.apache.org/jira/browse/HDFS-7864
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Jing Zhao
> Assignee: GAO Rui
> Attachments: HDFS-7864.1.patch, HDFS-7864.2.patch
>
>
> We need to update the safemode calculation for striped blocks. Specifically,
> each striped block now consists of multiple data/parity blocks stored in
> corresponding DataNodes. The current code's calculation is thus inconsistent:
> each striped block is only counted as 1 expected block, while each of its
> member block may increase the number of received blocks by 1.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
