[
https://issues.apache.org/jira/browse/HDFS-7054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14367512#comment-14367512
]
stack commented on HDFS-7054:
-----------------------------
Patch LGTM.
A few questions:
When would parents come back empty?
435 long parents[] = one.getTraceParents();
436 if (parents.length > 0) {
In hsync, the no arg method calls the method with an Enum and both get scope
and close when done. Could be a double-close. That is ok? We do it in both
methods because either could be called?
A test for the manipulation in getTraceParents?
> Make DFSOutputStream tracing more fine-grained
> ----------------------------------------------
>
> Key: HDFS-7054
> URL: https://issues.apache.org/jira/browse/HDFS-7054
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: datanode, namenode
> Affects Versions: 2.6.0
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Attachments: HDFS-7054.001.patch, HDFS-7054.002.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
