[
https://issues.apache.org/jira/browse/HDFS-7881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14371076#comment-14371076
]
Akira AJISAKA commented on HDFS-7881:
-------------------------------------
Thanks [~brahmareddy] for the update. Mostly looks good to me. Some minor
comments:
{code}
// Try to get the content length by parsing the content range
// because HftpFileSystem does not return the content length
// if the content is partial.
{code}
1. I'm thinking it's better to add the above comment between
{code}
if (cl == null) {
{code}
and
{code}
if (connection.getResponseCode() == HttpStatus.SC_PARTIAL_CONTENT) {
{code}
.
{code}
} catch (Exception ie) {
{code}
2. {{ie}} should be {{e}} since the expected exceptions are not {{IOException}}.
{code}
throw new IOException(
"failed to get content length by parsing the content range");
{code}
3. Would you add {{range}} and the original error message ({{e.getMessage()}})
to the error message?
> TestHftpFileSystem#testSeek fails in branch-2
> ---------------------------------------------
>
> Key: HDFS-7881
> URL: https://issues.apache.org/jira/browse/HDFS-7881
> Project: Hadoop HDFS
> Issue Type: Bug
> Affects Versions: 2.7.0
> Reporter: Akira AJISAKA
> Assignee: Brahma Reddy Battula
> Priority: Blocker
> Attachments: HDFS-7881-002.patch, HDFS-7881.patch
>
>
> TestHftpFileSystem#testSeek fails in branch-2.
> {code}
> -------------------------------------------------------
> T E S T S
> -------------------------------------------------------
> Running org.apache.hadoop.hdfs.web.TestHftpFileSystem
> Tests run: 14, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 6.201 sec
> <<< FAILURE! - in org.apache.hadoop.hdfs.web.TestHftpFileSystem
> testSeek(org.apache.hadoop.hdfs.web.TestHftpFileSystem) Time elapsed: 0.054
> sec <<< ERROR!
> java.io.IOException: Content-Length is missing: {null=[HTTP/1.1 206 Partial
> Content], Date=[Wed, 04 Mar 2015 05:32:30 GMT, Wed, 04 Mar 2015 05:32:30
> GMT], Expires=[Wed, 04 Mar 2015 05:32:30 GMT, Wed, 04 Mar 2015 05:32:30 GMT],
> Connection=[close], Content-Type=[text/plain; charset=utf-8],
> Server=[Jetty(6.1.26)], Content-Range=[bytes 7-9/10], Pragma=[no-cache,
> no-cache], Cache-Control=[no-cache]}
> at
> org.apache.hadoop.hdfs.web.ByteRangeInputStream.openInputStream(ByteRangeInputStream.java:132)
> at
> org.apache.hadoop.hdfs.web.ByteRangeInputStream.getInputStream(ByteRangeInputStream.java:104)
> at
> org.apache.hadoop.hdfs.web.ByteRangeInputStream.read(ByteRangeInputStream.java:181)
> at java.io.FilterInputStream.read(FilterInputStream.java:83)
> at
> org.apache.hadoop.hdfs.web.TestHftpFileSystem.testSeek(TestHftpFileSystem.java:253)
> Results :
> Tests in error:
> TestHftpFileSystem.testSeek:253 ยป IO Content-Length is missing:
> {null=[HTTP/1....
> Tests run: 14, Failures: 0, Errors: 1, Skipped: 0
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
