[
https://issues.apache.org/jira/browse/HDFS-7827?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jing Zhao updated HDFS-7827:
----------------------------
Attachment: HDFS-7827.004.patch
Thanks for updating the patch, Hui.
The new patch looks good to me. Some minors:
# In {{readINodeUnderConstruction}}, you still need to check if ERASURE_CODING
is supported in the image
# When loading an INodeFile with striped blocks, we do not need to pass in the
EC policy ID. More likely we will have different implementation to mark
files/directories as erasure coded.
# There are still a lot of places not following the coding convention.
Since these are not critical, I just made these changes on top of your patch.
Please see if 004 patch looks good to you.
> Erasure Coding: support striped blocks in non-protobuf fsimage
> --------------------------------------------------------------
>
> Key: HDFS-7827
> URL: https://issues.apache.org/jira/browse/HDFS-7827
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Jing Zhao
> Assignee: Hui Zheng
> Attachments: HDFS-7827.000.patch, HDFS-7827.002.patch,
> HDFS-7827.003.patch, HDFS-7827.004.patch
>
>
> HDFS-7749 only adds code to persist striped blocks to protobuf-based fsimage.
> We should also add this support to the non-protobuf fsimage since it is still
> used for use cases like offline image processing.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
