[
https://issues.apache.org/jira/browse/HDFS-7973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14376112#comment-14376112
]
Hadoop QA commented on HDFS-7973:
---------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12706515/HDFS-7973.001.patch
against trunk revision 0b9f12c.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests in
hadoop-hdfs-project/hadoop-hdfs:
org.apache.hadoop.tracing.TestTracing
The following test timeouts occurred in
hadoop-hdfs-project/hadoop-hdfs:
org.apache.hadoop.hdfs.server.blockmanagement.TestDatanodeManager
Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/10030//testReport/
Console output:
https://builds.apache.org/job/PreCommit-HDFS-Build/10030//console
This message is automatically generated.
> rename favoriteAndExcludedNodes to excludedNodes for clarity
> ------------------------------------------------------------
>
> Key: HDFS-7973
> URL: https://issues.apache.org/jira/browse/HDFS-7973
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: Walter Su
> Assignee: Walter Su
> Priority: Minor
> Attachments: HDFS-7973.001.patch
>
>
> two reasons:
> 1. name {{favoriteAndExcludedNodes}} is easily confusing.
> 2. {{DatanodeStorageInfo[] chooseTarget(..)}} should like {{private Node
> chooseTarget(..)}} use name {{oldExcludedNodes}} to backup {{excludedNodes}}.
> We should keep the consistency.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
