[ 
https://issues.apache.org/jira/browse/HDFS-7501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14378845#comment-14378845
 ] 

Hadoop QA commented on HDFS-7501:
---------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12706977/HDFS-7501-3.patch
  against trunk revision a16bfff.

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:green}+1 tests included{color}.  The patch appears to include 1 new 
or modified test files.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with 
eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

    {color:red}-1 core tests{color}.  The patch failed these unit tests in 
hadoop-hdfs-project/hadoop-hdfs:

                  org.apache.hadoop.hdfs.TestDFSClientRetries
                  org.apache.hadoop.tracing.TestTracing

Test results: 
https://builds.apache.org/job/PreCommit-HDFS-Build/10054//testReport/
Console output: 
https://builds.apache.org/job/PreCommit-HDFS-Build/10054//console

This message is automatically generated.

> TransactionsSinceLastCheckpoint can be negative on SBNs
> -------------------------------------------------------
>
>                 Key: HDFS-7501
>                 URL: https://issues.apache.org/jira/browse/HDFS-7501
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: namenode
>    Affects Versions: 2.5.0
>            Reporter: Harsh J
>            Assignee: Gautam Gopalakrishnan
>            Priority: Trivial
>         Attachments: HDFS-7501-2.patch, HDFS-7501-3.patch, HDFS-7501.patch
>
>
> The metric TransactionsSinceLastCheckpoint is derived as FSEditLog.txid minus 
> NNStorage.mostRecentCheckpointTxId.
> In Standby mode, the former does not increment beyond the loaded or 
> last-when-active value, but the latter does change due to checkpoints done 
> regularly in this mode. Thereby, the SBN will eventually end up showing 
> negative values for TransactionsSinceLastCheckpoint.
> This is not an issue as the metric only makes sense to be monitored on the 
> Active NameNode, but we should perhaps just show the value 0 by detecting if 
> the NN is in SBN form, as allowing a negative number is confusing to view 
> within a chart that tracks it.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to