[
https://issues.apache.org/jira/browse/HDFS-7978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14379126#comment-14379126
]
Walter Su commented on HDFS-7978:
---------------------------------
I just find out that common-logging doesn't support {} placeholder or variable
length argument lists. Sorry about that. You are right. We can switch over to
slf4j. There are still a lot class use common-logging. It's a long way to go.
I'll appreciate if you can apply the patch so we guard them now. Slf4j also
support isDebugEnabled(), I think it's ok. Or we can wait another patch for
switching to slf4j. Both works for me. Thanks introducing me Slf4j.
> Add LOG.isDebugEnabled() guard for some LOG.debug(..)
> -----------------------------------------------------
>
> Key: HDFS-7978
> URL: https://issues.apache.org/jira/browse/HDFS-7978
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: Walter Su
> Assignee: Walter Su
> Attachments: HDFS-7978.001.patch
>
>
> {{isDebugEnabled()}} is optional. But when there are :
> 1. lots of concatenating Strings
> 2. complicated function calls
> in the arguments, {{LOG.debug(..)}} should be guarded with
> {{LOG.isDebugEnabled()}} to avoid unnecessary arguments evaluation and impove
> performance.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
